This repository was archived by the owner on May 1, 2024. It is now read-only.
Conversation
2 tasks
jsuarezruiz
added
a/layout
i/high
PureWeen
suggested changes
Feb 4, 2021
Contributor
Author
Yeah, looks like this is somehow busting the default (text-only) cells. Looking into it. |
Contributor
Author
|
Okay, all relevant tests are passing. iOS 12 lane just isn't running, the iOS 14 failures are the known ListView issues, and the Android stuff is just flaky tests. |
rmarinho
approved these changes
Feb 5, 2021
Member
rmarinho
left a comment
rmarinho
left a comment
There was a problem hiding this comment.
Tested the nuget on the repos, and works as expected. I can see the controls now.
PureWeen
approved these changes
Feb 5, 2021
samhouts
added
a/collectionview
i/regression
t/bug 🐛
blocker
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Change
The change to on-demand layout resolution in 5.0.0-pre2 moved the layout resolution to the layout renderers. Unfortunately, this meant that some ContentView uses (13492) and any custom renderer which replaced the layout renderers (13418) would not update their layout changes properly.
These changes move the layout resolution call to the base VisualElementRenderer class on each platform; this way, they encompass content views and any custom layout renderers.
Issues Resolved
IsVisiblemodified via a binding/trigger #13551API Changes
None
Platforms Affected
Behavioral/Visual Changes
None
Before/After Screenshots
Not applicable
Testing Procedure
Unfortunately, this one is hard to write a test for without breaking all of Control Gallery. Best we can do is load up the repro projects from #13418 and #13492, apply the NuGet package from this PR, and verify that the problems are fixed.
For #13551 there is an automated UI test.
PR Checklist